Swift Driver Development Guide
- Things to Install
- The Code
- Running Tests
- Writing and Generating Documentation
- Linting and Style
- Code Review
Things to install
- swiftenv: a command-line tool that allows easy installation of and switching between versions of Swift.
- Jazzy: the tool we use to generate documentation.
- SwiftFormat: the Swift formatter we use.
- SwiftLint: the Swift linter we use.
- Sourcery: the tool we use for code generation.
You should clone this repository, as well as the MongoDB Driver specifications.
From the Command line
swift build or simply
make in the project’s root directory.
If you add symbols you may need to run
make exports which will generate Sources/MongoSwiftSync/Exports.swift. This makes symbols declared in
MongoSwift available to importers of
We do not provide or maintain an already-generated
.xcodeproj in our repository. Instead, you must generate it locally.
To generate the
- Install the Ruby gem
gem install xcodeproj(you may need to
- You’re ready to go! Open
MongoSwift.xcodeprojand build and test as normal.
Why is this necessary? The project requires a customized “copy resources” build phase to include various test
.json files. By default, this phase is not included when you run
swift package generate-xcodeproj. So
make project first generates the project, and then uses
xcodeproj to manually add the files to the appropriate targets (see
NOTE: Several of the tests require a mongod instance to be running on the default host/port,
localhost:27017. You can start this by running
mongod --setParameter enableTestCommands=1. The
enableTestCommands parameter is required to use some test-only commands built into MongoDB that we utilize in our tests, e.g.
You can run tests from Xcode as usual. If you prefer to test from the command line, keep reading.
From the Command Line
We recommend installing the ruby gem
xcpretty and running tests by executing
make test-pretty, as this provides output in a much more readable format. (Works on MacOS only.)
Alternatively, you can just run the tests with
swift test, or
To filter tests by regular expression:
- If you are using
swift test, provide the
--filterargument: for example,
swift test --filter=MongoClientTests.
- If you are using
make test-pretty, provide the
FILTERenvironment variable: for example,
make test-pretty FILTER=MongoCollectionTests.
Diagnosing Backtraces on Linux
SWIFT-755 documents an outstanding problem on Linux where backtraces do not contain debug symbols. As discussed in this Stack Overflow thread, a
symbolicate-linux-fatal script may be used to add symbols to an existing backtrace. Consider the following:
$ swift test --filter CrashingTest &> crash.log $ symbolicate-linux-fatal /path/to/MongoSwiftPackageTests.xctest crash.log
This will require you to manually provide the path to the compiled test binary (e.g.
Writing and Generating Documentation
We document new code as we write it. We use C-style documentation blocks (
/** ... */) for documentation longer than 3 lines, and triple-slash (
///) for shorter documentation.
Comments that are not documentation should use two slashes (
Documentation comments should generally be complete sentences and should end with periods.
Our documentation site is automatically generated from the source code using Jazzy. We regenerate it via our release script each time we release a new version of the driver.
If you’d like to preview how new documentation you’ve written will look when published, you can regenerate it by running
./etc/generate-docs.sh and then inspecting the generated HTML files in
Linting and Style
We use SwiftLint for linting. You can see our configuration in the
.swiftlint.yml file in the project’s root directory. Run
swiftlint in the root directory to lint all of our files. Running
swiftlint autocorrect will correct some types of violations.
We use SwiftFormat for formatting the code. You can see our configuration in the
.swiftformat file in the project’s root directory. Our linter config contains a superset of the rules that our formatter does, so some manual tweaking may be necessary to satisfy both once the formatter is run (e.g. line length enforcement). Most of the time, the formatter should put the code into a format that passes the linter. You can run the formatter on all of the files by running
swiftformat . from the root directory.
To pass all the formatting stages of our testing matrix, both
swiftlint --strict and
swiftformat --lint . must finish successfully.
If you have a setup for developing the driver in an editor other than the ones listed, or have found any useful tools/plugins for the listed editors, please open a pull request to add information!
- For syntax highlighting, install Decent Swift Syntax via Package Control.
- For linting integration with SwiftLint, install SublimeLinter and SublimeLinter-contrib-swiftlint via Package Control.
- You can get linting support by using
w0rp. This will show symbols in the gutter for warnings/errors and show linter messages in the status.
- swift.vim: A fork of Keith Smiley’s
swift.vimwith fixed indenting rules. This adds proper indenting and syntax for Swift to Vim. This fork also provides a match rule for column width highlighting.
- Please read the NOTICE for proper credits.
- Create a feature branch, named by the corresponding JIRA ticket if exists, along with a short descriptor of the work: for example,
- Do your work on the branch.
- If you add, remove, or rename any tests, make sure to update
LinuxMain.swiftaccordingly. If you are on MacOS, you can do that by running
- Ensure your code passes both the linter and the formatter.
- Make sure your code builds and passes all tests on:
- Travis. Every time you push to GitHub or open a pull request, it will trigger a new build, which includes running the linter, formatter, and basic tests.
- (If you work at MongoDB) Evergreen - Our Evergreen matrix tests a variety of MongoDB configurations, operating systems, and Swift language versions, and provides a way to more robustly test the driver. A new Evergreen build is automatically triggered for every commit to master, but for more complex pull requests it’s a good idea to run patches on Evergreen before merging.
- Open a pull request on the repository. Make sure you have rebased your branch onto the latest commits on
- Go through code review to get the team’s approval on your changes. (See the next section on Code Review for more details on this process.) Once you get the required approvals and your code passes all tests:
- Rebase on master again if needed.
- Rerun tests.
- Squash all commits into a single, descriptive commit method, formatted as:
TICKET-NUMBER: Description of changes. For example,
SWIFT-30: Implement WriteConcern type.
- Merge it, or if you don’t have permissions, ask someone to merge it for you.
Giving a review
When giving a review, please batch your comments together to cut down on the number of emails sent to others involved in the pull request. You can do this by going to the “Files Changed” tab. When you post your first comment, press “Start a review”. When you’re done commenting, click “Finish your review” (top right). Please feel free to leave reviews on your own code when you open a pull request in order add additional context, point out an aspect of the design you’re unsure of, etc.
Responding to a review
You can use the same batching approach as above to respond to review comments. Once you’ve posted your responses and pushed new commits addressing the comments, re-request reviews from your reviewers by clicking the arrow circle icons next to their names on the list of reviewers.
Note: GitHub allows marking comment threads on pull requests as “resolved”, which hides them from view. Always allow the original commenter to resolve a conversation. This allows them to verify that your changes match what they requested before the conversation is hidden.
- Swift Language Guide
- Swift Standard Library docs
- Swift by Sundell
- Swift Forums
- Some talks by Kaitlin: